Improve test filtering logic #194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two main issues:
Issue 1: Pytest Markers Were Dropped
Expected behavior:
Actual behavior (broken):
This caused tests to run without proper marker filtering, potentially executing GPU tests on CPU-only infrastructure.
Issue 2: Orphaned Tests Ran in Wrong Steps
Tests in directories not explicitly covered by a step's commands (e.g.,
v1/attention/) would be included based solely on the broadtests/v1dependency, even though the step's commands never test that directory.Example:
v1/core,v1/executor,v1/worker, etc.v1/attentiontests/v1/attention/test_attention_backends.pywould still be added to this stepTesting
Running on main -> Working normally
https://buildkite.com/vllm/ci/builds/35289/steps/canvas
Running on a problematic PR (vllm-project/vllm#26663) -> Fix working
https://buildkite.com/vllm/ci/builds/35290/steps/canvas